Thanks for all that.
Posted under General
This topic has been locked.
The diff link in a pool's history under Desc Chg gives the following error (and no description):
Error
undefined method `pool_version_diff' for #<#<Class:0x00005611fff43d20>:0x0000561200a0cd10> Did you mean? pool_versions_url post_version_diff pool_versions_path
DetailsActionView::Template::Error exception raised
app/views/pool_versions/diff.html.erb:6
Happens on any pool and diff, the only difference being the Class:... part.
Thanks for all the other updates.
DreamFromTheLayer said:
The diff link in a pool's history under Desc Chg gives the following error (and no description):
Happens on any pool and diff, the only difference being the Class:... part.
Created issue #4164.
error param that forces the API call to return an error. Example: /posts.json?error=500. API clients can use this to test error handling.Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.09-233212-utc...production-2019.09.17-071302-utc
evazion said:
- Made slight changes to the colors of various things. This is to make Danbooru's colorscheme more consistent in preparation for adding dark mode.
Flagged and deleted notices have the same color now. Maybe my memory is failing me, but wasn’t the flag notice light red and the deleted notice dark red before? Can’t tell them apart at a glance now.
I have to admit that there aren’t many color options left if we want to avoid both too light and too dark colors. #808080 (to go along with the deleted posts black borders) is probably too hard to read with both light and dark site color schemes.
Thanks for all your work~
Autocomplete after a "-" isn't working anymore (making it harder to exclude tags when searching and to remove mistags that weren't typos when editing posts). It also doesn't complete after tag type qualifiers (char: art: copy:), which might be considered a good change but I had used the previous behavior when creating tags as a realtime double-check that similar tags didn't already exist
I think the colors of the box containing parent and child posts are messed up.
When you select the parent, the box turns yellow (used to be green), when you select a child it turns green (used to be yellow).
The borders of the image are remaining the original colors.
I don't know if this is intended or not, but its sort of confusing in contrast with what it used to be.
fossilnix said:
Autocomplete after a "-" isn't working anymore (making it harder to exclude tags when searching and to remove mistags that weren't typos when editing posts). It also doesn't complete after tag type qualifiers (char: art: copy:), which might be considered a good change but I had used the previous behavior when creating tags as a realtime double-check that similar tags didn't already exist
No those aren't desired behaviors. Yes it was an accident. Additinally, it removed the ability to to use the OR operator "~".
I created issue #4169 for the above.
kittey said:
Flagged and deleted notices have the same color now. Maybe my memory is failing me, but wasn’t the flag notice light red and the deleted notice dark red before? Can’t tell them apart at a glance now.
I have to admit that there aren’t many color options left if we want to avoid both too light and too dark colors. #808080 (to go along with the deleted posts black borders) is probably too hard to read with both light and dark site color schemes.
Thanks for all your work~
This was intentional. I'm working on simplifying Danbooru's color palette to make our colorscheme more coherent. Right now we have dozens of unique colors and eight different shades of red alone, which is way too many. I want to reduce this down to eight or so primary colors with two or three shades per color, at most four.
As for flag notices in particular, I'm considering making flags part of the pending notice and getting rid of separate flag notices. This would save some space above posts and would be more consistent with deleted notices (which include the flags rather than putting them in a separate notice).
evazion said:
Site update
Changes
- Added dark mode. To enable it, go to your account settings and change the Theme setting to "dark".
Thank you so much for this!
evazion said:
Site update
Changes
- Added dark mode. To enable it, go to your account settings and change the Theme setting to "dark".
- Changed styling of buttons to be consistent across browsers. Buttons may appear slightly different, depending on your browser.
- Removed the tag size indicator bars behind tag counts on the /tags page. This interfered with dark mode and wasn't especially useful.
Fixes
- Fixed the search button in the tag search box wrapping over to the next line on Firefox.
- Fixed the artist commentary box not having a gap between it and the search navbar when the search navbar is beneath the post (the default setting).
Works okay, but I wish there was more black in the background for AMOLED screens.
Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.17-071302-utc...production-2019.09.24-033335-utc
Jarlath said:
Works okay, but I wish there was more black in the background for AMOLED screens.
I made it a little darker and may tweak it some more. I don't plan on going to pure black though, as I think it's too harsh. If you want to adjust the colors yourself you can do so with this custom CSS:
body[data-user-theme="dark"] {
--body-background-color: black;
}
Minor update:
evazion said:
Minor update:
- Added support for new https://www.pixiv.net/en/artworks/76710422 urls.
I saw that this afternoon. Not sure why they did it, but I was wondering.
Also, this is pretty close to what I wanted, but I'll use the custom CSS as well. Many thanks.
Full changelog: https://github.com/r888888888/danbooru/compare/production-2019.09.24-033335-utc...production-2019.09.30-175649-utc
Whatever changes made to the site in the background seem to bork its appearance on Chrome (on iOS 8.4), putting the thumbnails to the bottom of the page. Going to the post page, the pic seems to be hidden and I have to click "Resize to Window" for the pic to show. I'm not even using mobile mode.
Site works fine elsewhere (Chromium Edge Dev and Chrome on Android).