Danbooru

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

DanmakuShooter said:

Seen the fix for mobile. It works for the notes, but now the top menu (the one you open with that blue thing beside the site's name) is behind everything else. So you can't click on parts of it.
In posts it's like this - https://my.mixtape.moe/klsxqi.png
In the pools section it's even worse, can't click on almost anything. Also the input fields are larger than the rest of the page - https://my.mixtape.moe/iuhewy.png

issue #3016 should fix the menu and the messed up inputs.

kittey said:

What are the security implications of that? We don’t want to allow HTML injection.

If the Twitter API gives us escaped HTML, shouldn’t we just be able to use that? > is already fine; we just don’t have to escape it to >.

We never trust the commentary or insert it verbatim without escaping it. Commentary is run through DText as the final step, which escapes any HTML. Which is the problem - we always escape it ourselves, so if something higher up escaped it already, it ends up double-escaped.

FaithSummers said:

artist #4845
"Invalid scheme format: (C76) [Clesta (Cle Masahiro)] CL-orz"

API looks even worse, giving massive backtrace: https://defuse.ca/b/wcnIEzE4rjYFvVEH6eKAJH

This has been fixed.

Mikaeri said:

Still seems that pawoo sources aren't fixed when uploading from the bookmarklet. Sorry if I'm being kind of pushy with the agenda, even though there's no real rush. (I just don't want to keep having to fix sources or let people know to fix them)

Submitted issue #3019. I think the remaining tasks are fetching tags/commentary and fixing the artist finder so that it doesn't return bogus results when a pawoo source doesn't match an artist.

evazion said:

We never trust the commentary or insert it verbatim without escaping it. Commentary is run through DText as the final step, which escapes any HTML. Which is the problem - we always escape it ourselves, so if something higher up escaped it already, it ends up double-escaped.

Yeah, Type-kun already mentioned the correct solution for it: just unescape whatever comes from Twitter and then let DText escape it reliably.

Let me know if this is the right thread

When I logged in today I found 8 pics from Qpax that suddenly appeared in my favorites. Not everything Qpax posted, but all 8 are pics Qpax posted, from the last 13 or so hours.

I checked some other pics from Qpax from around that time, and most of them have massive favorite numbers

dandan said:

Let me know if this is the right thread

When I logged in today I found 8 pics from Qpax that suddenly appeared in my favorites. Not everything Qpax posted, but all 8 are pics Qpax posted, from the last 13 or so hours.

I checked some other pics from Qpax from around that time, and most of them have massive favorite numbers

Maybe some image samples got deleted and the favorites were transferred to the newly-uploaded full size versions. Do you remember having favorited any of those posts in the past? Do they have deleted child posts? (Deleted child posts don't show up by default, scroll down on one of the posts and click "find similar" in the sidebar)

EDIT: Qpax mentioned moving a bunch of favorites to the new versions yesterday in topic #13646/p11. I'm pretty sure that's what you're seeing

fossilnix said:

Maybe some image samples got deleted and the favorites were transferred to the newly-uploaded full size versions. Do you remember having favorited any of those posts in the past? Do they have deleted child posts? (Deleted child posts don't show up by default, scroll down on one of the posts and click "find similar" in the sidebar)

EDIT: Qpax mentioned moving a bunch of favorites to the new versions yesterday in topic #13646/p11. I'm pretty sure that's what you're seeing

to be honest, once I reached my original limit for favorites, some 4 years ago, I forgot about them. Only recently I have added a couple, but I couldn't really tell if those that popped up again were already in the old favorites or not

Still, thanks for the reply, it really wasn't an issue and I'm glad that it wasn't because somebody tried to mess with my account or something like that

BrokenEagle98 said:

This seems to have only affected post #100000. It was moved to the S3 server, but was still using the old image URLs. Submitted issue #3020.

I'm sure I've seen some other posts that had images missing just like post #100000. Unfortunately I didn't note their IDs because I thought that it is a temporary issue.

I only remember that those posts were older than post #100000 and that original and sample were missing while thumbnail was still available.

MyrMindservant said:

I'm sure I've seen some other posts that had images missing just like post #100000. Unfortunately I didn't note their IDs because I thought that it is a temporary issue.

I only remember that those posts were older than post #100000 and that original and sample were missing while thumbnail was still available.

If you happen to come across them again, please make sure to make a note of them in this thread. If this occurs often enough, it may even behoove us to create a new thread to report these.

I keep getting this message everytime I'm trying to upload things:

Too Many Requests

Please rate limit yourself

------------------------

It's not limited on uploading, but also occurs when submitting tags after editing.

Updated

Sacriven said:

I keep getting this message everytime I'm trying to upload things:

Too Many Requests

Please rate limit yourself

------------------------

It's not limited on uploading, but also occurs when submitting tags after editing.

Same, I keep getting this message when I try to do something right after an upload, like adding a source or uploading another image.

Sacriven said:

I keep getting this message everytime I'm trying to upload things:

Too Many Requests

Please rate limit yourself

------------------------

It's not limited on uploading, but also occurs when submitting tags after editing.

I'm also getting this when attempting to mark a post or commentary as translated. I'm able to get the action to go through successfully a minute or two later, but it'll crop up again elsewhere.

I've also noticed that a couple of notes I've translated have not initially posted. The first time, I thought I'd simply forgotten to save the note changes, but after the second time, I'm beginning to think it's associated with this glitch. Rather than indicate there was a problem saving the note or pop up the "Too Many Requests" message, it just ignores the Save request on the note.

The above messages come about if you exhaust your API requests in a given time period. As Builders, your burst limit would be 60 with a regen of 4 per second. Also, I believe things were changed a while back so that all requests to the site count, whether they be HTML, JSON or XML.

Still, the above is strange since I hit the site frequently with massive amounts of requests done one after the other, but since they each take about half a second to complete I have never broken my API limit.

So, I have no idea why you are generating so many API requests to bust your limits...? ¯\_(ツ)_/¯

I don't know either. I was just trying to use a tag script on about ~10 posts (since I wanted to correct a character name) but it kept giving me errors. Same with the wikipages I just made.

BrokenEagle98 said:

The above messages come about if you exhaust your API requests in a given time period. As Builders, your burst limit would be 60 with a regen of 4 per second. Also, I believe things were changed a while back so that all requests to the site count, whether they be HTML, JSON or XML.

Still, the above is strange since I hit the site frequently with massive amounts of requests done one after the other, but since they each take about half a second to complete I have never broken my API limit.

So, I have no idea why you are generating so many API requests to bust your limits...? ¯\_(ツ)_/¯

Well, four Builders experiences the same thing means something. I mean, I uploaded 2 batch of pics yesterday and didn't have any problem about API requests. Something is definitely going on in the background.