Danbooru

Danbooru 2 Issues Topic

Posted under General

This topic has been locked.

evazion said:

@Sacriven: post links of the things not being flagged as duplicates. I'm guessing it's because of the url change. New i.pximg.net sources no longer match existing i1.pixiv.net sources, so the "This post was probably already uploaded" check (which is essentially just a source:https://i.pximg.net/img-original/img/2016/10/23/01/52/53/59595179_p1.png search) won't trigger.

I already forgot those links. Back then I was doing a twenty batch uploads and found those accidentally.

TARDISES said:

The site seems to be having constant statement timeouts on pages with rather high numbers, which makes navigation completely impossible!

Which pages? Going very deep into search results is known to be slow, even on normal days. The failboorus are surely making it worse. You can either

  • edit the url to say page=b99999999999 to force switching to next/prev navigation.
  • add id:0..100000, id:100000..200000 constraints to your searches so they have fewer pages.
  • upgrade to gold to raise the statement timeout.

Sacriven said:

@evazion

I found one of the batch that wasn't detected as duplicates.

They aren't detected because the sources don't match:

For it to work, all posts would either have to be normalized to the old https://i4.pixiv.net/ domain (which I'm not sure will continue to work given they're moving away from it), or to https://i.pximg.net, which would mean changing the source of every pixiv post on the site.

evazion said:

They aren't detected because the sources don't match:

For it to work, all posts would either have to be normalized to the old https://i4.pixiv.net/ domain (which I'm not sure will continue to work given they're moving away from it), or to https://i.pximg.net, which would mean changing the source of every pixiv post on the site.

How strange. Assuming that the uploader of those also use bookmarklet, why the image sources link can be different for me and him?

Sacriven said:

How strange. Assuming that the uploader of those also use bookmarklet, why the image sources link can be different for me and him?

When you use the bookmarklet on an image type link...
https://i.pximg.net/img-original/img/2017/04/02/17/14/50/62217791_p0.jpg
...then it uses the link as-is for the source.

When you use the bookmarklet on a post type link...
http://www.pixiv.net/member_illust.php?mode=medium&illust_id=59595179
...Danbooru uses the Pixiv API to grab the image link, and the API still returns the old-style image links.

BrokenEagle98 said:

When you use the bookmarklet on a post type link...
http://www.pixiv.net/member_illust.php?mode=medium&illust_id=59595179
...Danbooru uses the Pixiv API to grab the image link, and the API still returns the old-style image links.

Papi returns old-style links, i guess?
Because aapi work as it should:
https://app-api.pixiv.net/v1/illust/detail?illust_id=59595179
(No auth requred, should be visible for all)
Why they need 2 apis, i wonder. With different links. Make no sense.

Fremy said:

Papi returns old-style links, i guess?
Because aapi work as it should:
https://app-api.pixiv.net/v1/illust/detail?illust_id=59595179
(No auth requred, should be visible for all)
Why they need 2 apis, i wonder. With different links. Make no sense.

Yeah, just for reference, the following is what PAPI returns using the same above post.

JSON data
[
  {
    "is_manga": true,
    "width": 900,
    "content_type": null,
    "id": 59595179,
    "created_time": "2016-10-23 01:52:53",
    "title": "\u30ac\u30eb\u30d1\u30f3\u307e\u3068\u3081",
    "image_urls": {
      "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0.png",
      "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_master1200.jpg",
      "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_square1200.jpg",
      "small": "http:\/\/i4.pixiv.net\/c\/150x150\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_master1200.jpg",
      "medium": "http:\/\/i4.pixiv.net\/c\/600x600\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_master1200.jpg"
    },
    "tags": [
      "\u30ac\u30eb\u30d1\u30f3",
      "\u30ac\u30fc\u30eb\u30ba&\u30d1\u30f3\u30c4\u30a1\u30fc",
      "\u9038\u898b\u30a8\u30ea\u30ab",
      "\u897f\u4f4f\u307f\u307b",
      "\u30aa\u30ec\u30f3\u30b8\u30da\u30b3(GuP)",
      "\u30da\u30d1\u30ed\u30cb",
      "\u5b87\u6d25\u6728\u512a\u5b63",
      "\u307f\u307b\u30a8\u30ea"
    ],
    "tools": [
      
    ],
    "book_style": "none",
    "metadata": {
      "pages": [
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p0_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p1.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p1_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p1_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p1_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p2.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p2_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p2_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p2_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p3.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p3_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p3_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p3_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p4.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p4_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p4_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p4_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p5.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p5_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p5_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p5_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p6.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p6_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p6_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p6_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p7.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p7_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p7_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p7_square1200.jpg"
          }
        },
        {
          "image_urls": {
            "large": "http:\/\/i4.pixiv.net\/img-original\/img\/2016\/10\/23\/01\/52\/53\/59595179_p8.png",
            "px_480mw": "http:\/\/i4.pixiv.net\/c\/480x960\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p8_master1200.jpg",
            "medium": "http:\/\/i4.pixiv.net\/c\/1200x1200\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p8_master1200.jpg",
            "px_128x128": "http:\/\/i4.pixiv.net\/c\/128x128\/img-master\/img\/2016\/10\/23\/01\/52\/53\/59595179_p8_square1200.jpg"
          }
        }
      ]
    },
    "age_limit": "all-age",
    "caption": "\u9038\u898b\u30a8\u30ea\u30ab\u591a\u3081\u3067\u3059\u3002",
    "publicity": 0,
    "favorite_id": 0,
    "stats": {
      "views_count": 2666,
      "commented_count": 1,
      "score": 1286,
      "scored_count": 129,
      "favorited_count": {
        "public": 112,
        "private": 7
      }
    },
    "type": "illustration",
    "height": 1286,
    "is_liked": false,
    "user": {
      "id": 18634583,
      "is_premium": null,
      "name": "\u30b7\u30b7\u30e3\u30e2\u5b50\u7235",
      "is_follower": false,
      "profile_image_urls": {
        "px_50x50": "http:\/\/i2.pixiv.net\/user-profile\/img\/2016\/08\/07\/22\/13\/34\/11312273_f79fe9749efcbc354a7bb6532752db7f_50.png"
      },
      "profile": null,
      "is_following": false,
      "is_friend": false,
      "stats": null,
      "account": "ktle12"
    },
    "reuploaded_time": "2016-10-23 01:52:53",
    "page_count": 9
  }
]

You can see that it returned the old-style image links.

Site update (2017.03.30 - 2017.04.04)
Features
  • issue #2951: /post_versions is no longer super slow.
  • http://i.pximg.net sources should be fully supported. For real this time. Maybe.
  • User profiles link to the tag changes report. This report compares tags added by the uploader vs. tags added by everyone else. This is useful for spotting frequently forgotten tags or habitual undertagging.
Fixes
  • issue #2950: it was possible for invalid post versions to be created if there was a failure in the middle of saving or uploading a post. Likewise with pools.
  • issue #2958: it was possible for a post to be half-approved if there was a failure in the middle of approving it.
  • issue #2953: the tag change report didn't correctly attribute tags that the uploader removed themselves.
  • issue #2959: moving favorites didn't move hidden favs.
  • issue #2957: uploading http://i.pximg.net manga gallery pages uploaded the sample instead of the full size.
  • issue #2500: the animated_gif / animated_png tags were automatically removed and couldn't be added again when editing posts below post #10000.
  • issue #2946: the sidebar didn't link to the html page for http://i.pximg.net sources.

Full changelog: https://github.com/r888888888/danbooru/compare/production-2017.03.30-173015-utc...production-2017.04.04-203407-utc

I get this bug when attempting to move favorites on a pending post (post #2680632):

NoMethodError exception raised
undefined method `user' for #<Favorite id: 49135645, user_id: 19831, post_id: 2680632> Did you mean? user_id
app/models/post.rb:1286:in `block in give_favorites_to_parent'
app/models/post.rb:1285:in `give_favorites_to_parent'
app/models/post.rb:1360:in `block in delete!'
app/models/post.rb:1349:in `delete!'
app/controllers/moderator/post/posts_controller.rb:16:in `delete'

The post then appears as 'flagged' while still pending in the blue queue, so the status shows up as both Pending and Flagged.

Hmmm... strange.

Also, moving favorites now (on an already deleted post) results in this error:

undefined method `user' for #<Favorite id: 32614470, user_id: 245315, post_id: 1919634> Did you mean? user_id
app/models/post.rb:1286:in `block in give_favorites_to_parent'
app/models/post.rb:1285:in `give_favorites_to_parent'
app/controllers/moderator/post/posts_controller.rb:33:in `move_favorites'