Blacklists out of order

I've just noticed that blacklisting stopped doing anything. That is, you still get the "Hidden: 11" line in the post list, and can click on the specific criteria to toggle them, but the actual thumbnails are at all times visible.

I think it still worked this morning, which would be about 20h ago. Anyone else see that? I've checked on a non-chromium browser just to make sure it's not because I just upgraded to a newer nightly, but I see the same bug on gecko as well.

I'm getting the same problem. I also had the database timeout on me as well.

Yup, it's broken here also. Probably has something to do with that short downtime we had a little while ago?

Ditto; though I originally thought my 'blacklist' cookie had just gotten corrupted, or something like that. Guess it's server-side.

But ooh, guess who got to see tentacles and spread genitals against their will today?

It's a bug introduced by http://trac.donmai.us/ticket/1047. I've submitted a patch to fix it.

Good to know, evazion. Been waiting for an implementation like that for a while.

Though, introducing the blacklisted preview image may potentially interrupt the fluidity of browsing, for those of us who are avid consecutive middle-clickers. Though, I doubt that'll even be a problem at all. And if it is, I could just use a user script to fix it anyway. So meh.

Either way, thumbs up on this.

Edit: On the other hand, in those instances where one would want to take a temporary gander at blacklisted images, it'll be a *lot* easier to know where they are now.

Once again, thanks for the fix!

The blacklist still works on comments it seems!

EDIT: whoops more discussion appeared. Thanks for the patch evazion!

Can someone explain to me how to use this patch i'm pretty new to this.

hoodrager said:
Can someone explain to me how to use this patch i'm pretty new to this.

You don't "use" the patch.

To put it simply, just wait a little while, and the problem will correct itself. You don't have to do anything.

Confirming that, after the daily Downbooru, it's still not working properly. I had been seeing the 'blacklisted' image previously, and was happy with that, but now it's back to showing them, thumbnails and all.
So, the blacklist does nothing at the moment, other than add a thing in the sidebar saying how many images should be hidden, but aren't. :\

Ah, I was just about to say something about this.
Let's hope it gets fixed soon.

sgcdonmai said:
[...] daily Downbooru [...]

I've always had a hunch, but was never really sure if it was happening to other users, if any. I could've asked about it, but I assumed there were reasons for that.

And of course, it's already been mentioned that blacklists have not yet returned to functioning, so I needn't say more.

sgcdonmai said:
[...] daily Downbooru [...]

Lalaca said:
I've always had a hunch, but was never really sure if it was happening to other users, if any. I could've asked about it, but I assumed there were reasons for that.

Yeah, it's everyday around noon for a few minutes.
I have been getting network timeout errors and thumbnails not loading properly sometimes though (only recently)
Anyone else having these problems?

Fred1515 said:
I have been getting network timeout errors and thumbnails not loading properly sometimes though (only recently)
Anyone else having these problems?

It's been slow for a long time, then it got fast again, then it got slow again a few days back. Very, very annoying, especially with chromium's peculiar caching implementation, which makes it almost impossible to recover once an image times out in the middle of transmission. I developed a habit of pressing reload or stop/start a lot, but it definitely makes things way painful and has a very noticeable negative impact on the quality of my moderating and tagging. I guess one of these days I will finally sit down and work on that dedicated danbrowser project of mine.

I see.

May I ask what is this danbrowser project? It certainly sounds interesting.

A tool I wanted to write to make my daily moderation routine less painful. Danbooru (and browser UIs in general) really falls apart in many ways when you try to push it past its useful limits, and I've been doing it for the past couple of years. It's time I finally fixed it.

Seems to be working now.

I think I may have just ran into a slight issue regarding blacklists just now.

It seems that while a page's thumbnails are loading, the 'blacklisted' thumbnail image isn't applied until *after* all of the thumbnails are downloaded - and that's just long enough to have a glimpse at content that should normally be blacklisted.

But of course, if the blacklisted thumbnail image is cached, this probably wouldn't happen. But this still presents *possible* scenarios where a user would see content that should be otherwise blacklisted (albeit, only briefly).

And I just saw a really gross image that was on my blacklist because of this, so something's not right. Maybe this should be looked into?

Edit: Ok, the blacklisted thumbnail image is definitely in my cache, but this still appears to be happening sometimes for some reason.

I'm beginning to think it might be better to roll it back to when blacklisted images showed up only as links, at least until this issue gets resolved.

I believe that bug has always existed, although it wasn't as noticeable previously because it only affected the comments page. The problem is that the javascript that replaces thumbnails only runs after the thumbnails are loaded. moe.imouto's code has a fix for this; I'll look into porting it to Danbooru.