How to: submit source code contributions

After searching trough trac, forum and wiki I finally came to the conclusion that there is no such thing like a guideline for submitting source code contributions to the danbooru software.

That's why I would like to know

* if source code contributions are accepted at all (You never know…).
* how contributions should be provided. Attach a patch to the specific trac ticket? Send it via email? Ask for write access to the svn repository (unlikely)?
* if there is some order how tickets should be handled and does this affect the acceptance of the patch?
* Where discussions regarding the specific patches are handled. I would assume this would happen in the ticket comments.

I've submitted some patches before, so I guess I'm qualified to answer this. I'm not speaking for albert here; these are just my personal observations.

if source code contributions are accepted at all (You never know…).

In my experience, yes. I've mostly just submitted small bug fixes though, so YMMV. Major changes should probably be discussed beforehand.

how contributions should be provided. Attach a patch to the specific trac ticket? Send it via email? Ask for write access to the svn repository (unlikely)?

I generate patches by running 'svn diff' then I attach them to the trac ticket. I don't know what albert prefers, but this seems easiest to me.

if there is some order how tickets should be handled and does this affect the acceptance of the patch?

Not really. If you've got patches then submit them, it doesn't really matter how old the ticket is.

Where discussions regarding the specific patches are handled. I would assume this would happen in the ticket comments.

Changes visible to users should be discussed on the forums, unless it's something really minor. Otherwise, use trac.

If you do attach a patch to an old ticket, please change the title to add [patch] so that I can see it. Or email it to me. I generally do accept patches. I don't accept large scale changes unless it's been vetted and approved on the forum.

Thanks for your replies evazion and albert.